Obesity and smoking have been associated with poor prostate cancer (PC) outcomes. We investigated associations between obesity and biochemical recurrence (BCR), metastasis, castrate resistant-PC (CRPC), PC-specific mortality (PCSM), and all-cause mortality (ACM) and examined if smoking modified these associations.